fix(deno): Enable sessions for HTTP requests by AG0708 · Pull Request #23313 · getsentry/sentry-javascript

AG0708 · 2026-08-11T23:58:52Z

Deno's node:http server integration disabled release-health sessions even
though the shared HTTP instrumentation enables them by default. Keeping the
shared default aligns Deno with the other server runtimes and restores session
aggregates for incoming requests when a release is configured.

Root cause

The Deno integration passed sessions: false when it subscribed to shared HTTP
server instrumentation. There is no Deno-specific duplicate instrumentation
that requires that override.

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
Link an issue if there is one related to your pull request.

Fixes #22888

JPeer264 · 2026-08-13T12:31:01Z

Hey @AG0708 thanks for your contribution. May I ask if there is an existing issue for this?

But I see that the JSDoc actually says that the default is true.

AG0708 · 2026-08-14T19:39:52Z

Yes—this addresses #22888, which reports that the Deno HTTP integration hard-codes sessions: false despite the shared instrumentation default. The PR body also includes Fixes #22888.

AG0708 · 2026-08-14T19:42:58Z

I rebased this branch onto current develop (71f66dc4), which includes #23391, the upstream pin for the LangChain ESM export failure seen in all five red Node integration jobs. Those failures were in the untouched tracing/langchain/v1 suite; the Deno-focused package tests, transpile, type builds, lint, and formatting had passed before the rebase. The refreshed CI run should now exercise this patch with that upstream dependency fix included.

github-actions · 2026-08-17T10:13:09Z

👋 @mydea, @JPeer264 — Please review this PR when you get a chance!

Deno disabled release-health sessions for incoming node:http requests even though the shared HTTP instrumentation defaults them on. Preserve the shared default and cover it with a real request regression test. Co-Authored-By: OpenAI Codex <codex@openai.com> Signed-off-by: Abhinav Gorrepati <gorrepatiabhinav1@gmail.com>

isaacs · 2026-08-18T15:37:31Z

This is the simple targeted fix that makes sessions: true the default. However, it also makes it no longer configurable, which isn't great. What we need to do is extend the options object type and forward them all to the upstream method, so that defaults are aligned with the other HTTP instrumentations.

Pushed a fixup commit which should address this. Waiting on CI.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ded3cdd. Configure here.}

…P requests

AG0708 marked this pull request as ready for review August 12, 2026 01:15

AG0708 requested a review from a team as a code owner August 12, 2026 01:15

AG0708 requested review from JPeer264 and mydea and removed request for a team August 12, 2026 01:15

AG0708 marked this pull request as draft August 12, 2026 07:54

AG0708 force-pushed the codex/22888-deno-http-sessions branch from 9eb32ec to 71f66dc Compare August 14, 2026 19:42

AG0708 marked this pull request as ready for review August 15, 2026 19:31

cursor Bot reviewed Aug 18, 2026

View reviewed changes